feat: introduce API for partial share providers #57285
Merged
+193
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salmart-dev
force-pushed
the
feature/54562/support-partial-share-providers
branch
2 times, most recently
from
262fee8 to
147446b
Compare
salmart-dev
requested review from
Altahrim,
CarlSchwan,
leftybournes,
miaulalala,
sorbaugh and
yemkareems
and removed request for
a team,
Altahrim,
leftybournes,
miaulalala,
sorbaugh and
yemkareems
Member
|
The comment about returning items for both the path and it's children also applies here. |
icewind1991
reviewed
Dec 29, 2025
Contributor
Author
I think the answer is pretty similar to the one I gave in the other PR. Unfortunately due to the sequence of calls in setupForPath (first by $path without children and then with children) this is leaking also here... |
This was referenced Dec 30, 2025
Adds support for retrieval of shares by path Signed-off-by: Salvatore Martire <[email protected]>
salmart-dev
force-pushed
the
feature/54562/support-partial-share-providers
branch
from
147446b to
a449af6
Compare
icewind1991
approved these changes
Dec 30, 2025
sorbaugh
approved these changes
Dec 30, 2025
AndyScherzinger
deleted the
feature/54562/support-partial-share-providers
branch
artonge
added a commit
that referenced
this pull request
Jan 14, 2026
Follow-up of #57285 This ensure that the behavior is the same and reduce code duplication. Salvatore's version seems to be more optimized, but I prefer those change to be done separately and for both methods. Signed-off-by: Louis Chmn <[email protected]>
artonge
added a commit
that referenced
this pull request
Jan 14, 2026
Follow-up of #57285 This ensure that the behavior is the same and reduce code duplication. Salvatore's version seems to be more optimized, but I prefer those change to be done separately and for both methods. Signed-off-by: Louis Chmn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for retrieval of shares by path
Summary
Introduces API to fetch shares received by a user by path. Needed for providing support for partial mount providers.
TODO
Checklist
3. to review, feature component)stable32)